----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100728 -----------------------------------------------------------
Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752, 38753, 38754, 38755, 38756] All tests passed. - Mesos ReviewBot On Sept. 25, 2015, 11:19 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38756/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 11:19 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3385 > https://issues.apache.org/jira/browse/MESOS-3385 > > > Repository: mesos > > > Description > ------- > > CMake: Add support for compiling the agent with CMake. > > > Diffs > ----- > > CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > src/CMakeLists.txt PRE-CREATION > src/cmake/MesosProtobuf.cmake PRE-CREATION > src/slave/cmake/SlaveConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/38756/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >