> On Sept. 28, 2015, 6:03 p.m., Neil Conway wrote: > > 3rdparty/libprocess/src/socket.cpp, line 77 > > <https://reviews.apache.org/r/38809/diff/1/?file=1085970#file1085970line77> > > > > Why is this conditional on socketFd?
The idea is I am only responsible for the resource I allocated. If a socketfd is passed in, I leave it to the owner to free it; if a socketfd is created by me, I will free it. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100831 ----------------------------------------------------------- On Sept. 28, 2015, 9:07 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38809/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 9:07 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3519 > https://issues.apache.org/jira/browse/MESOS-3519 > > > Repository: mesos > > > Description > ------- > > socket: refactor to use Option and fix file descriptor leaks. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 817cb3711742871630a13b966563296644008f21 > 3rdparty/libprocess/src/socket.cpp 5879423bd92c5805353a962cbd822a993b0568c5 > > Diff: https://reviews.apache.org/r/38809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
