----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100867 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 193) <https://reviews.apache.org/r/38580/#comment158112> We need to also insert into the tracker when we start a new download src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 196) <https://reviews.apache.org/r/38580/#comment158113> We don't need a dispatch here src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 218) <https://reviews.apache.org/r/38580/#comment158120> you can skip this whole .then and merge with the above onAny. src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 245) <https://reviews.apache.org/r/38580/#comment158118> You can call onAny here, then you don't need to return anything. src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 257) <https://reviews.apache.org/r/38580/#comment158119> kill the return src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 297) <https://reviews.apache.org/r/38580/#comment158121> We should return failure when timeout is <= 0 instead of just using the default and hide the bad input. src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 313) <https://reviews.apache.org/r/38580/#comment158114> Space between foreach and ( src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 331) <https://reviews.apache.org/r/38580/#comment158116> No need to return src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 338) <https://reviews.apache.org/r/38580/#comment158115> ditto - Timothy Chen On Sept. 28, 2015, 8:39 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38580/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 8:39 p.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > First iteration with basic functionality. > > > Diffs > ----- > > src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 > src/slave/containerizer/provisioner/docker/local_puller.hpp > 4574e8a04663482625d7b54f765741f221ec13e0 > src/slave/containerizer/provisioner/docker/local_puller.cpp > 4a0b7d11f013941084571f2d89d835a4668a3d8b > src/slave/containerizer/provisioner/docker/puller.hpp > 105b4e75439c2ad4c08e2fd364f288f1d39b9b59 > src/slave/containerizer/provisioner/docker/registry_client.cpp > 0a9663139b8a6d9e4fa458f7c893d33ca3a30e90 > src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp > cbb67686d45513f0395a0cf1bc5c43cb4935adae > > Diff: https://reviews.apache.org/r/38580/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
