> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 317 > > <https://reviews.apache.org/r/38580/diff/7/?file=1088724#file1088724line317> > > > > Why break down layer timeout? Why not just one timeout? > > > > And how is the user able to configure this pull timeout in the first > > place? > > > > If we don't have give users the option to change this I suggest > > removing this from the interface and let's just use constants for now.
The only reason being that user wont care about manifest vs pull timeout. They would care only about the total timeout. The split is so that we can cap their individual timeouts. I havent added a flag for timeout and the interface uses Option so that if its not passed in, we use the default. We currently use constant default. > On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 209 > > <https://reviews.apache.org/r/38580/diff/7/?file=1088724#file1088724line209> > > > > using namespace process and you can get rid of process:: here, we do > > that everywhere I thought we are moving away from "using namespace process" ? - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101261 ----------------------------------------------------------- On Oct. 1, 2015, 6:40 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38580/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 6:40 p.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Integrated remote puller with store. Tests will follow. > > > Diffs > ----- > > src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 > src/slave/containerizer/provisioner/docker/local_puller.hpp > 4574e8a04663482625d7b54f765741f221ec13e0 > src/slave/containerizer/provisioner/docker/local_puller.cpp > 4a0b7d11f013941084571f2d89d835a4668a3d8b > src/slave/containerizer/provisioner/docker/puller.hpp > 105b4e75439c2ad4c08e2fd364f288f1d39b9b59 > src/slave/containerizer/provisioner/docker/puller.cpp > cb05324689ffa26ce830b513e2d71b55517da3cb > src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp > cbb67686d45513f0395a0cf1bc5c43cb4935adae > src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 > src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 > > Diff: https://reviews.apache.org/r/38580/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
