> On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 191 > > <https://reviews.apache.org/r/38747/diff/7/?file=1084907#file1084907line191> > > > > I believe this leaks "fd".
good catch. > On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 222 > > <https://reviews.apache.org/r/38747/diff/7/?file=1084907#file1084907line222> > > > > Why do we initialize this to `{0}`? initialization of auto variables - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100835 ----------------------------------------------------------- On Sept. 25, 2015, 8:33 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 8:33 p.m.) > > > Review request for mesos, Gilbert Song and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added SHA256, SHA512 implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/digest.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
