> On Sept. 29, 2015, 9:17 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/src/tests/digest_tests.cpp, line 58
> > <https://reviews.apache.org/r/38747/diff/11/?file=1087208#file1087208line58>
> >
> >     What's the motivation behind having both simple and dynamic 
> > verification?

"Simple" gives you the ability to call a digest (say SHA 256) directly if you 
already know the type. The dynamic part is so that the client code does not 
have to do the selection. Use cases like the docker registry where the sha type 
is dynamic, the client code will have to do the dynamic call. By keeping it 
central, this logic need not be repeated everywhere.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review101018
-----------------------------------------------------------


On Sept. 29, 2015, 9:40 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38747/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 9:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added SHA256, SHA512 implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/Makefile.am 
> fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> a14b5b8fe22d3e75bef3c716ae7865ddaf132927 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38747/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to