> On Sept. 29, 2015, 6:32 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp, line 134
> > <https://reviews.apache.org/r/38328/diff/1/?file=1069299#file1069299line134>
> >
> >     Hm.. looks like this file needs a pass to phrase the errors as "Failed 
> > to invoke stat" to be consistent with our other messages, also we should 
> > avoiding printing the path since the caller will do that when composing the 
> > error message, yeah?

Just wanted to be consistent with the rest in this file. Will follow up with a 
patch to cleanup the error message.


> On Sept. 29, 2015, 6:32 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp, lines 
> > 129-138
> > <https://reviews.apache.org/r/38328/diff/1/?file=1069299#file1069299line129>
> >
> >     I believe you also need an UNIMPLEMENTED version inside 
> > windows/stat.hpp.

yeah, good catch.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38328/#review100986
-----------------------------------------------------------


On Sept. 12, 2015, 6:36 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38328/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 6:36 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-3349
>     https://issues.apache.org/jira/browse/MESOS-3349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper to get stat.st_dev in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 
> c7084f1d3672f5610de1cb47e275cb67a9cac1d5 
> 
> Diff: https://reviews.apache.org/r/38328/diff/
> 
> 
> Testing
> -------
> 
> trivial.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to