----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/#review101011 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem/linux.cpp (lines 88 - 94) <https://reviews.apache.org/r/38858/#comment158316> This has appeared in multiple places, perhaps refactor this into a helper? src/slave/containerizer/isolators/filesystem/linux.cpp (line 121) <https://reviews.apache.org/r/38858/#comment158317> Suggestion, refactor to avoid the nesting? if (workDirMount.isNone() { // mount it and get the fs::MountInfoTable::Entry } // Check it's a slave mount. // Check it's a shared mount. src/slave/containerizer/isolators/filesystem/linux.cpp (line 126) <https://reviews.apache.org/r/38858/#comment158314> If it's already mounted (so it's in /etc/mtab) there's no reason to shell out; you can use fs::mount(). src/slave/containerizer/isolators/filesystem/linux.cpp (line 146) <https://reviews.apache.org/r/38858/#comment158315> If it's already mounted (so it's in /etc/mtab) there's no reason to shell out; you can use fs::mount(). src/tests/containerizer/filesystem_isolator_tests.cpp (lines 926 - 930) <https://reviews.apache.org/r/38858/#comment158318> This doesn't verify the work_dir *is* bind mounted, just that *if* it is then it's a shared mount... src/tests/containerizer/filesystem_isolator_tests.cpp (lines 949 - 953) <https://reviews.apache.org/r/38858/#comment158319> Ditto. - Ian Downes On Sept. 29, 2015, 12:48 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38858/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 12:48 p.m.) > > > Review request for mesos, Timothy Chen and Jiang Yan Xu. > > > Bugs: MESOS-3539 > https://issues.apache.org/jira/browse/MESOS-3539 > > > Repository: mesos > > > Description > ------- > > Ensured that slave's work_dir is a shared mount in its own peer group when > LinuxFilesystemIsolator is used. > > This addressed the TODO in the current code. > > > Diffs > ----- > > src/slave/containerizer/isolators/filesystem/linux.cpp > 8fa929f12838044762be82287e1b71440cccc6d9 > src/tests/containerizer/filesystem_isolator_tests.cpp > 41d098c7d66eba0befc3708c6660a6a3e5f0d2de > > Diff: https://reviews.apache.org/r/38858/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
