> On Oct. 1, 2015, 6:49 p.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 557 > > <https://reviews.apache.org/r/38579/diff/4/?file=1088717#file1088717line557> > > > > Is this a bug fix? What was wrong? And why the tests pass before?
Its not a bug fix. GetManifest used to return layers in the order of fsLayers. But its now changed to match what store expects. The tests passed earlier becasue the code and tests were expecting the same order. Now that the order has been reversed in the code, the test had to be updated. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101263 ----------------------------------------------------------- On Oct. 1, 2015, 6:39 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38579/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 6:39 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > - Moved ManifestResponse struct from RegistryClient to namespace. > - Cleanup > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/registry_client.hpp > 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 > src/slave/containerizer/provisioner/docker/registry_client.cpp > c2040b48ea43fdb29766994c244273d3fa9ee3cd > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38579/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
