> On Oct. 2, 2015, 11:16 p.m., Ben Mahler wrote:
> > src/slave/containerizer/provisioner/docker/registry_client.hpp, lines 36-40
> > <https://reviews.apache.org/r/38579/diff/5/?file=1088841#file1088841line36>
> >
> >     Hm.. any reason the registry client is nested within the containerizer?
> >     
> >     A registry client seems like a general abstraction, should it live up 
> > alongside the `Docker` abstraction within src/docker?

There is more to this decision than what meets the eye :). I will give it a 
shot to explain. registry client and tokenmanager does "registry" specific 
things. They serve the privisioner right now. Registry namespace was created to 
highlight the regitry domain for provisioners. There was also a thought to keep 
the registry classes in its own directory. But that was later undone. Since the 
classes RegistryClient and TokenManager now lie in the provisioner dierctory, 
the file names are fully qualified. 

That is the "descriptive" explanation but is not normative.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/#review101382
-----------------------------------------------------------


On Oct. 2, 2015, 12:24 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38579/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 12:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Moved ManifestResponse struct from RegistryClient to namespace.
> - Cleanup
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38579/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to