----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/#review101375 -----------------------------------------------------------
docs/networking.md (line 16) <https://reviews.apache.org/r/38963/#comment158739> s/networking support/networking support in Mesos/ docs/networking.md (line 18) <https://reviews.apache.org/r/38963/#comment158741> s/in version 0.25.0/in version 0.25.0 to .../ docs/networking.md (line 19) <https://reviews.apache.org/r/38963/#comment158742> backwards compatible? Opt in? docs/networking.md (line 22) <https://reviews.apache.org/r/38963/#comment158743> s/briefly // docs/networking.md (line 23) <https://reviews.apache.org/r/38963/#comment158744> s/ip/IP/ docs/networking.md (line 34) <https://reviews.apache.org/r/38963/#comment158745> s/basis/manner/ docs/networking.md (line 35) <https://reviews.apache.org/r/38963/#comment158746> s/handled/handle/ docs/networking.md (line 43) <https://reviews.apache.org/r/38963/#comment158793> I like this! docs/networking.md (line 69) <https://reviews.apache.org/r/38963/#comment158794> s/contianer/container/ docs/networking.md (line 70) <https://reviews.apache.org/r/38963/#comment158795> s/ip/IP/ docs/networking.md (lines 95 - 96) <https://reviews.apache.org/r/38963/#comment158796> (And makes it to the scheduler :) Is that worth mentioning here? docs/networking.md (line 102) <https://reviews.apache.org/r/38963/#comment158797> Would it make sense to enumerate failure modes here? (If the scheduler fails, if the master fails, ...) docs/networking.md (line 113) <https://reviews.apache.org/r/38963/#comment158798> Let's ask the community; but I'd assume that we would avoid references to repos which are not hosted by github.com/apache/mesos or github.com/mesos - maybe it is fine, but let's make sure docs/networking.md (line 146) <https://reviews.apache.org/r/38963/#comment158799> But must be supported by that given net module provider, right? docs/networking.md (line 165) <https://reviews.apache.org/r/38963/#comment158792> Are those hard tabs? docs/networking.md (line 222) <https://reviews.apache.org/r/38963/#comment158800> s/Note!/NOTE:/ See some of the other user docs for the format. docs/networking.md (line 228) <https://reviews.apache.org/r/38963/#comment158801> s/many // docs/networking.md (line 247) <https://reviews.apache.org/r/38963/#comment158802> Kill double spaces :) docs/networking.md (line 251) <https://reviews.apache.org/r/38963/#comment158803> NOTE: docs/networking.md (line 253) <https://reviews.apache.org/r/38963/#comment158804> s/sets /sets it's/? docs/networking.md (line 260) <https://reviews.apache.org/r/38963/#comment158805> s/fulfil/fulfill/ - Niklas Nielsen On Oct. 2, 2015, 11:08 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38963/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 11:08 a.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-3561 > https://issues.apache.org/jira/browse/MESOS-3561 > > > Repository: mesos > > > Description > ------- > > Added initial draft of networking user-doc. > > > Diffs > ----- > > docs/images/networking-architecture.png PRE-CREATION > docs/networking.md PRE-CREATION > > Diff: https://reviews.apache.org/r/38963/diff/ > > > Testing > ------- > > Markdown rendering at > https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md > > > Thanks, > > Kapil Arya > >
