> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, lines 95-96
> > <https://reviews.apache.org/r/38963/diff/1/?file=1089029#file1089029line95>
> >
> >     (And makes it to the scheduler :) Is that worth mentioning here?

It's mentioned in the next bullet point :).


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 102
> > <https://reviews.apache.org/r/38963/diff/1/?file=1089029#file1089029line102>
> >
> >     Would it make sense to enumerate failure modes here? (If the scheduler 
> > fails, if the master fails, ...)

It's a implementation specific concern. Not sure if/how we should capture it.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 113
> > <https://reviews.apache.org/r/38963/diff/1/?file=1089029#file1089029line113>
> >
> >     Let's ask the community; but I'd assume that we would avoid references 
> > to repos which are not hosted by github.com/apache/mesos or 
> > github.com/mesos - maybe it is fine, but let's make sure

Will send an email shortly.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 165
> > <https://reviews.apache.org/r/38963/diff/1/?file=1089029#file1089029line165>
> >
> >     Are those hard tabs?

Nope, just spaces.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101375
-----------------------------------------------------------


On Oct. 5, 2015, 3:52 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 3:52 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
>     https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -----
> 
>   docs/home.md f8c2b62 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking-for-mesos-managed-containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> -------
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to