-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101534
-----------------------------------------------------------

Ship it!


Looks great hsaodent! Thanks for your patience, just a couple of minor things 
and we can land this :)


src/master/main.cpp (line 325)
<https://reviews.apache.org/r/37024/#comment158951>

    Could you do this after logging initialization to keep it consistent with 
the other mains?



src/slave/main.cpp (line 255)
<https://reviews.apache.org/r/37024/#comment158950>

    Could you do this after logging initialization to keep it consistent with 
the other mains?



src/version/version.hpp (line 43)
<https://reviews.apache.org/r/37024/#comment158952>

    Can you avoid the static non-POD here?



src/version/version.cpp (line 58)
<https://reviews.apache.org/r/37024/#comment158953>

    newline here? :)


- Ben Mahler


On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
>     https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add an endpoint that exposes component version.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> -------
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to