> On 十月 7, 2015, 10:01 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/help.cpp, lines 60-63
> > <https://reviews.apache.org/r/39037/diff/2/?file=1092216#file1092216line60>
> >
> >     In your last diff you didn't have this change and the one below to 
> > conditionally add newlines, why did you introduce it when changing it to 
> > Option?
> >     
> >     If we want to change this behavior, let's do it in another patch since 
> > it seems independent from making 'description' optional. Keep independent 
> > changes in separate patches :)

bmahler, I think that the changes are needed to be in this patch since adding 
"\n" is the old behavior. What haosdent is doing now is updating the logic to 
align with his new change of making description as optional.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/#review101821
-----------------------------------------------------------


On 十月 7, 2015, 3:04 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39037/
> -----------------------------------------------------------
> 
> (Updated 十月 7, 2015, 3:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
>     https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow description empty in help information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 
> e7dc670648e8abd2fef7be79835f0b71e3e91258 
>   3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 
> 
> Diff: https://reviews.apache.org/r/39037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to