----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review102346 -----------------------------------------------------------
Ship it! Thanks for your patience Tim! Looks good, just some minor comments (let's remove isStatus now that we don't have to do the casting stuff). 3rdparty/libprocess/include/process/http.hpp (lines 416 - 419) <https://reviews.apache.org/r/38416/#comment159955> This is no longer necessary, yes? Callers can just do an equality check against 'code'. 3rdparty/libprocess/src/decoder.hpp (lines 444 - 447) <https://reviews.apache.org/r/38416/#comment159956> Looks like this check should take place before setting the code and status, since it's validating the code. 3rdparty/libprocess/src/decoder.hpp (lines 656 - 659) <https://reviews.apache.org/r/38416/#comment159957> Ditto here, can you move this above the setting of the code and status? 3rdparty/libprocess/src/http.cpp (line 121) <https://reviews.apache.org/r/38416/#comment159958> Brace on newline :) 3rdparty/libprocess/src/tests/benchmarks.cpp (line 264) <https://reviews.apache.org/r/38416/#comment159959> Per my comment above, let's remove isStatus and just directly do equality against the 'code' field. Ditto for the other cases below. 3rdparty/libprocess/src/tests/http_tests.cpp (lines 128 - 130) <https://reviews.apache.org/r/38416/#comment159960> Could you use the -> operator here and in all of the code below to avoid the .get(). mess? Thanks Tim! - Ben Mahler On Oct. 8, 2015, 11:05 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38416/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 11:05 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, > and Jiang Yan Xu. > > > Bugs: MESOS-3429 > https://issues.apache.org/jira/browse/MESOS-3429 > > > Repository: mesos > > > Description > ------- > > Allow HTTP response codes to be checked with code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 591c1a959057155e1bf0f5bd73352e78d1c15cb3 > 3rdparty/libprocess/src/decoder.hpp > 53b8079968a0145651bad9d11aa4be2b504de57a > 3rdparty/libprocess/src/http.cpp ebf76093d654397260fc8da84c4f2b0fd6541483 > 3rdparty/libprocess/src/process.cpp > d1c81f1d244f02bf42cab97198587ce1b8c7c407 > 3rdparty/libprocess/src/tests/benchmarks.cpp > bb9ced8933bf2bb97ae6b3cffdb5528676e53c11 > 3rdparty/libprocess/src/tests/http_tests.cpp > 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472 > 3rdparty/libprocess/src/tests/process_tests.cpp > ffd260a3fa2e49b3de183ba7b392b71afaaba2e5 > > Diff: https://reviews.apache.org/r/38416/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
