> On Oct. 6, 2015, 9:53 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 76 > > <https://reviews.apache.org/r/38416/diff/5/?file=1092048#file1092048line76> > > > > We avoid static non-POD types due to destruction issues. Can you put > > this on the heap? > > > > Per my suggestion above, perhaps we can have `Status::string(uint16_t > > code)` as a static function on the `Status` class that provides the string > > version of the status. > > > > This should clean up the tests as well.
I'm not sure how this will clean up the tests since you need to still check if the code is in the statuses map, I think it just avoids the lookup yourself. Anyhow I'm going to update the review as you suggested. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review101692 ----------------------------------------------------------- On Oct. 6, 2015, 8:27 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38416/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 8:27 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, > and Jiang Yan Xu. > > > Bugs: MESOS-3429 > https://issues.apache.org/jira/browse/MESOS-3429 > > > Repository: mesos > > > Description > ------- > > Allow HTTP response codes to be checked with code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 591c1a959057155e1bf0f5bd73352e78d1c15cb3 > 3rdparty/libprocess/src/decoder.hpp > 53b8079968a0145651bad9d11aa4be2b504de57a > 3rdparty/libprocess/src/http.cpp ebf76093d654397260fc8da84c4f2b0fd6541483 > 3rdparty/libprocess/src/process.cpp > d1c81f1d244f02bf42cab97198587ce1b8c7c407 > 3rdparty/libprocess/src/tests/benchmarks.cpp > bb9ced8933bf2bb97ae6b3cffdb5528676e53c11 > 3rdparty/libprocess/src/tests/http_tests.cpp > 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472 > 3rdparty/libprocess/src/tests/process_tests.cpp > ffd260a3fa2e49b3de183ba7b392b71afaaba2e5 > > Diff: https://reviews.apache.org/r/38416/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
