> On Oct. 12, 2015, 9:03 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 1100-1101 > > <https://reviews.apache.org/r/38746/diff/3/?file=1096299#file1096299line1100> > > > > Shall we say why it's "bad"? i.e. the default value when a caller > > doesn't check for presence is 0 and so ideally the 0 reason is not a valid > > one.
Done. Thanks! > On Oct. 12, 2015, 9:03 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 1673-1695 > > <https://reviews.apache.org/r/38746/diff/3/?file=1096310#file1096310line1673> > > > > It's still a little unsettling that these container update / launch > > failure cases don't properly set the executor state to > > Executor::TERMINATING, can you at least add a TODO in these to signal the > > reader of the code? > > > > Curious what we can do to simplify all of these redundant container > > update failure cases, worth thinking about later.. Yes, I'll follow up with a patch shortly. Working on it. I'll add a TODO for now. > On Oct. 12, 2015, 9:03 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 1105-1107 > > <https://reviews.apache.org/r/38746/diff/3/?file=1096299#file1096299line1105> > > > > Would be nice to have these renames in the upgrade notes, mentioning > > that the numbers are backwards compatible but there needs to be a compile > > time adjustment for those relying on REASON_MEMORY_LIMIT :) Expecting a small patch shortly. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102317 ----------------------------------------------------------- On Oct. 12, 2015, 7:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38746/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 7:33 p.m.) > > > Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. > > > Bugs: MESOS-2035 > https://issues.apache.org/jira/browse/MESOS-2035 > > > Repository: mesos > > > Description > ------- > > Added TaskStatus::Reason to containerizer Termination message. > > The following doc summarized the problem and proposed a solution: > https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing > > > Diffs > ----- > > include/mesos/containerizer/containerizer.proto > f16ccc89f83da28c413ccfa0687a06b7515a605c > include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 > include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed > src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 > src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b > src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf > src/slave/containerizer/external_containerizer.cpp > 211649201777f0d2ce802a865090129eacdd53be > src/slave/containerizer/isolators/cgroups/mem.cpp > 89c86beb9227eb8a6e70a413e7b3934add652981 > src/slave/containerizer/isolators/posix/disk.cpp > c324c79f8d598095d07fbcb26e806a0978c2a520 > src/slave/containerizer/mesos/containerizer.hpp > 4c1419290645ad4c44360a81618a6cea7ad190df > src/slave/containerizer/mesos/containerizer.cpp > b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 > src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 > src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c > src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a > src/tests/containerizer/docker_containerizer_tests.cpp > 8771ef661039310d79845513ea4602e15b2ad13d > src/tests/containerizer/mesos_containerizer_tests.cpp > 5bc7d408bda0c249e1b66747d8bd87e688362e6c > src/tests/oversubscription_tests.cpp > 2cf047e6ae061c1b9eed6238e1df67c91ab3514a > src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb > src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb > > Diff: https://reviews.apache.org/r/38746/diff/ > > > Testing > ------- > > sudo make check > > tested with Docker as well. > > > Thanks, > > Jie Yu > >
