----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review102433 -----------------------------------------------------------
src/master/http.cpp (line 787) <https://reviews.apache.org/r/36913/#comment160094> Let's add the corresponding HELP function for this. src/master/http.cpp (lines 790 - 800) <https://reviews.apache.org/r/36913/#comment160082> I don't think we need the `else if`s here. ``` if (a) { return ...; } if (b) { return ...; } ``` This provides the opportunity to comment above each block and makes it easier to see each termination block. src/master/http.cpp (line 799) <https://reviews.apache.org/r/36913/#comment160083> Can we mentioned what the method is in this error? You can use the maintenance endpoints as an example. src/master/master.hpp (line 842) <https://reviews.apache.org/r/36913/#comment160092> s/actor is/actor. It is/ src/master/master.hpp (line 1020) <https://reviews.apache.org/r/36913/#comment160095> Let's add a comment that we are starting to partition some of the Admin APIs into classes to keep related endpoints together in a "module". - Joris Van Remoortere On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:55 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Joris Van Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > ----- > > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 > src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
