> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 843 > > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line843> > > > > What about return quotaHandler.delete(request); > > > > It is better that the operation API can map to CRUD
We wanted to make the name consistent across all calls. @alex: Any preference? > On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 839 > > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line839> > > > > what about "return quotaHandler.create(request)" Wanted to make names consistent. @alex: any preference? - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review103518 ----------------------------------------------------------- On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 1:03 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Joris Van Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > ----- > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
