> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote: > > Would it be possible to add a few unit tests, also to show usage patterns? > > especially given the absence of any documentation, it's kinda difficult to > > figure out how is this "intended to work" and, without tests, whether it > > works at all. > > Niklas Nielsen wrote: > Alex: Ping ^^
Sure, I just haven't had time to look into this yet. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102245 ----------------------------------------------------------- On Oct. 2, 2015, 10:11 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38627/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 10:11 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-3232 > https://issues.apache.org/jira/browse/MESOS-3232 > > > Repository: mesos > > > Description > ------- > > Allows developers to provide their own parameters when loading modules > instead of using the ones provided by the user when loading Mesos. This helps > to deal with default modules (those used when the user doesn't provide any), > and for testing of the modules. > > > Diffs > ----- > > src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef > src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 > > Diff: https://reviews.apache.org/r/38627/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >