----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103005 -----------------------------------------------------------
src/docker/executor.cpp <https://reviews.apache.org/r/39386/#comment160853> What happens when you remove this fallback, taken a user don't provide the launcher dir? - Niklas Nielsen On Oct. 15, 2015, 10:17 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39386/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 10:17 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3738 > https://issues.apache.org/jira/browse/MESOS-3738 > > > Repository: mesos > > > Description > ------- > > Fix uncorrect launcher dir in docker executor. > > > Diffs > ----- > > src/docker/executor.hpp 8ab4e98c41017e8420b98c63a59d8e4bc1a99172 > src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade > src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d > > Diff: https://reviews.apache.org/r/39386/diff/ > > > Testing > ------- > > * make check > * make install and then test with marathon to check if launcher_dir passes > correctly. > > > Thanks, > > haosdent huang > >
