> On Oct. 16, 2015, 11:34 p.m., Niklas Nielsen wrote:
> > src/docker/executor.cpp, line 581
> > <https://reviews.apache.org/r/39386/diff/1/?file=1099658#file1099658line581>
> >
> >     What happens when you remove this fallback, taken a user don't provide 
> > the launcher dir?

Hi, @nnielsen. Do you mean when user don't provide `launcher_dir` here, what it 
would happend? `launcher_dir` is a require option here, if user don't provide 
it, the executor would exit.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39386/#review103005
-----------------------------------------------------------


On Oct. 19, 2015, 2:59 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39386/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 2:59 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3738
>     https://issues.apache.org/jira/browse/MESOS-3738
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix uncorrect launcher dir in docker executor.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 
>   src/docker/executor.hpp 8ab4e98c41017e8420b98c63a59d8e4bc1a99172 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
>   src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
> 
> Diff: https://reviews.apache.org/r/39386/diff/
> 
> 
> Testing
> -------
> 
> * make check
> * make install and then test with marathon to check if launcher_dir passes 
> correctly.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to