-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review103042
-----------------------------------------------------------



src/common/resources.cpp (line 274)
<https://reviews.apache.org/r/39018/#comment160880>

    `s/validateParsedResource/validateCommandLineResource/`?



src/common/resources.cpp (line 277)
<https://reviews.apache.org/r/39018/#comment160881>

    Remove newline



src/common/resources.cpp (lines 280 - 281)
<https://reviews.apache.org/r/39018/#comment160882>

    Might be better to print out the `stringify(resource)` rather than just the 
`resource.name()`?



src/common/resources.cpp (line 316)
<https://reviews.apache.org/r/39018/#comment160885>

    The `nameTypes` parameter of this function is a in/out parameter. This 
pattern is generally discouraged, since reasoning about the state injected into 
this function as well as the non-local side-effects made within this function 
is difficult to reason about.
    
    While it may be slightly less performant, I think we can make 
`validateParsedResource` be `validateParsedResources` and encapsulate this test 
within that function. What do you think?



src/common/resources.cpp (line 377)
<https://reviews.apache.org/r/39018/#comment160883>

    I think you need to check for `resource.role() == "*"` instead, since 
`role` has `[default = "*"]`. Please verify.



src/common/resources.cpp (line 483)
<https://reviews.apache.org/r/39018/#comment160884>

    Remove newline.


- Michael Park


On Oct. 14, 2015, 3:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
>     https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review 
> (https://reviews.apache.org/r/39102/).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> -------
> 
> New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were 
> added: `ResourcesTest.ParsingFromJSONWithRoles` and 
> `ResourcesTest.ParsingFromJSONError`. These attempt to test common error 
> scenarios that might show up in user-supplied JSON.
> 
> `make check` was used to confirm that all tests pass, with one notable 
> failure (ResourcesTest.ParsingFromJSONError) related to a picojson issue 
> tracked here: https://issues.apache.org/jira/browse/MESOS-3698
> 
> The original resources parsing format is used throughout many other tests 
> (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the 
> original parsing continues to work correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to