> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 182-189
> > <https://reviews.apache.org/r/38342/diff/6/?file=1099828#file1099828line182>
> >
> > Indent 2 spaces, not the strings themselves, but within the strings.
>
> Klaus Ma wrote:
> The 2 sparces indent are in the strings, do you mean we should move it
> out?
I mean at the `[ ... ]` level:
```cpp
"["
" {"
" \"id\": \"message1\","
" \"numbers\": [1, 2]"
" },"
" {"
" \"id\": \"message2\","
" \"numbers\": [1, 2]"
" }"
"]"
```
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review103078
-----------------------------------------------------------
On Oct. 16, 2015, 9:56 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 9:56 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
>
>
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField<T>` by
> introducing overloaded functions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9
>
> Diff: https://reviews.apache.org/r/38342/diff/
>
>
> Testing
> -------
>
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
>
>
> Thanks,
>
> Klaus Ma
>
>
