-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
-----------------------------------------------------------



docs/scheduler-http-api.md (lines 28 - 36)
<https://reviews.apache.org/r/39452/#comment161169>

    This text isn't helpful.
    
    I wanted a grammar that defined what the RecordIO format was, having the 
formal grammar removes any subtelties of examples.
    
    Here is a grammar that reflects RecordIO:
    
    ```
    records         = *record
    
    record          = record-size LF
                      record-data
    
    record-size     = 1*DIGIT
    record-data     = record-size(OCTET)
    ```
    
    `record-size` should be interpreted as an unsigned 64-bit integer (uint64)



docs/scheduler-http-api.md (lines 38 - 57)
<https://reviews.apache.org/r/39452/#comment161170>

    The rest of the HTTP API Documentation is language agnostic and I feel 
strongly that it should be kept that way.
    
    Please remove this example. In the future when there are implementations 
available they can be linked to in an appendix.



docs/scheduler-http-api.md (line 59)
<https://reviews.apache.org/r/39452/#comment161171>

    +1


- Ben Whitehead


On Oct. 19, 2015, 2:07 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 2:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
>     https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to