> On Oct. 20, 2015, 1:03 a.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, lines 38-57
> > <https://reviews.apache.org/r/39452/diff/2/?file=1101221#file1101221line38>
> >
> >     The rest of the HTTP API Documentation is language agnostic and I feel 
> > strongly that it should be kept that way.
> >     
> >     Please remove this example. In the future when there are 
> > implementations available they can be linked to in an appendix.

I tend to agree with BenW here. Let's add pseudo code instead of python code 
here in addition to the suggested ABNF grammar. Borrowed from: 
https://dev.twitter.com/streaming/overview/processing ( Delimited section )

```
while (true) {
  do {
    lengthBytes = readline()
  } while (lengthBytes.length < 1)
  messageLength = parseInt(lengthBytes);
  messageBytes = read(messageLength);
  process(messageBytes);
}
```

What do you think ?


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
-----------------------------------------------------------


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
>     https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to