----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review103336 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 2339) <https://reviews.apache.org/r/39276/#comment161347> s/handle/handled/ s/si/is/ 3rdparty/libprocess/src/process.cpp (line 2344) <https://reviews.apache.org/r/39276/#comment161350> There is something wrong with the commas and periods - please check with a native speaker. 3rdparty/libprocess/src/process.cpp (line 2346) <https://reviews.apache.org/r/39276/#comment161349> The existing is incorrect but not sure which option is correct: A. s/event's/events'/ B. s/event's/event/ 3rdparty/libprocess/src/tests/http_tests.cpp (lines 1155 - 1161) <https://reviews.apache.org/r/39276/#comment161346> Great description! 3rdparty/libprocess/src/tests/http_tests.cpp (line 1156) <https://reviews.apache.org/r/39276/#comment161345> s/to/two/ 3rdparty/libprocess/src/tests/http_tests.cpp (line 1261) <https://reviews.apache.org/r/39276/#comment161344> s/expecting/expected/ s/finished its/finished processing its/ - Till Toenshoff On Oct. 16, 2015, 7:28 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39276/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 7:28 a.m.) > > > Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff. > > > Bugs: MESOS-3705 > https://issues.apache.org/jira/browse/MESOS-3705 > > > Repository: mesos > > > Description > ------- > > When using the same socket to send multiple HTTP requests to different > actors. If the actor responsible for handling the first request is stuck > handling another event while a subsequent request can reply immediatly, the > order of the responses is altered violating HTTP Pipelining. > > This patch fixes that problem enforcing that every response is sent in the > order the corresponding request arrived. It also adds a test to reproduce the > issue and verify the fix works. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > 16ddbd77afa6efdf6bad201aa497ee102aa863ae > 3rdparty/libprocess/src/process.cpp > 954d31424bc8f8ecfa78b80513c480f2514ec271 > 3rdparty/libprocess/src/tests/http_tests.cpp > d13d3888abbf3db552df4a9f83e54667e598ded9 > > Diff: https://reviews.apache.org/r/39276/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
