-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39514/#review103375
-----------------------------------------------------------



src/master/validation.cpp (line 74)
<https://reviews.apache.org/r/39514/#comment161392>

    Please also check it whether `empty()` after trim. The length of string 
will never <0.



src/master/validation.cpp (line 75)
<https://reviews.apache.org/r/39514/#comment161393>

    Any UT case for empty user?


- Klaus Ma


On Oct. 21, 2015, 4:48 p.m., Liqiang Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39514/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:48 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3747
>     https://issues.apache.org/jira/browse/MESOS-3747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add validation to check whether FrameworkInfo.user be empty. Fail
> framework action if framework user is empty.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
>   src/master/validation.cpp 9c7c8c123c5bd13b99a2c1c7318515d687b4bc34 
> 
> Diff: https://reviews.apache.org/r/39514/diff/
> 
> 
> Testing
> -------
> 
> make check done.
> 
> 
> Thanks,
> 
> Liqiang Lin
> 
>

Reply via email to