----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39514/#review103440 -----------------------------------------------------------
Thanks for this; please add reviewers to this patch, and find a shepherd. include/mesos/v1/mesos.proto (lines 211 - 213) <https://reviews.apache.org/r/39514/#comment161494> I know it's not your code, but could you please remove `automagically` (there's nothing magic in a string assignment :) Please use: `SchedulerDriver` The comment could read more easily if you changed it to: ``` // When the Scheduler HTTP API is used for registering the framework, // the `user` field should be explicitly set, unless the // `--switch_user` flag is explicitly set to `false` on // the agent nodes (otherwise, the tasks will fail). // For the same reason, if the user is set, it should be an // existing user on the agent nodes, with the necessary permissions. src/master/validation.cpp (lines 73 - 76) <https://reviews.apache.org/r/39514/#comment161496> an emtpy user is a valid user case, for when the agent is set to `--switch_user=false`: you should not prevent this outright. however, as this may cause confusing errors, I would be perfectly fine with a LOG(WARN) telling the caller that if he sees tasks failing this may be the reason: ``` LOG(WARN) << "You have not set a user to run the task as on the agent; " << "unless the --switch_user is set to `false` on the agent " << "this may cause tasks to fail"; ``` - Marco Massenzio On Oct. 21, 2015, 8:48 a.m., Liqiang Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39514/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:48 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3747 > https://issues.apache.org/jira/browse/MESOS-3747 > > > Repository: mesos > > > Description > ------- > > Add validation to check whether FrameworkInfo.user be empty. Fail > framework action if framework user is empty. > > > Diffs > ----- > > include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a > src/master/validation.cpp 9c7c8c123c5bd13b99a2c1c7318515d687b4bc34 > > Diff: https://reviews.apache.org/r/39514/diff/ > > > Testing > ------- > > make check done. > > > Thanks, > > Liqiang Lin > >
