-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review103449
-----------------------------------------------------------
Looks good!
I haven't tested this myself yet, so these are preliminary comments.
Please split any reviews into {stout, libprocess, mesos}. Also, please put any
unrelated cleanups into a separate review.
3rdparty/libprocess/3rdparty/Makefile.am (line 128)
<https://reviews.apache.org/r/39345/#comment161502>
s/intialize/Initialize/
3rdparty/libprocess/3rdparty/Makefile.am (line 242)
<https://reviews.apache.org/r/39345/#comment161503>
Can you add a comment that FreeBSD includes all the dynamic linking stuff
in libc.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 257)
<https://reviews.apache.org/r/39345/#comment161504>
What happens if/when we support IPv6?
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 288 - 290)
<https://reviews.apache.org/r/39345/#comment161505>
IIRC, FreeBSD doesn't often use patch versions, but has in the past. Pretty
sure I started with 4.6.2!
3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp (lines 22 - 24)
<https://reviews.apache.org/r/39345/#comment161506>
Alphabetize please.
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp (lines 20 -
25)
<https://reviews.apache.org/r/39345/#comment161507>
Alphabetize please.
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (lines 84 - 86)
<https://reviews.apache.org/r/39345/#comment161508>
Alphabetize.
3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (line 28)
<https://reviews.apache.org/r/39345/#comment161509>
When does/will FreeBSD changes its libc version?
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (lines 419 - 421)
<https://reviews.apache.org/r/39345/#comment161511>
Could you condition this on security.jail.jailed?
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 755)
<https://reviews.apache.org/r/39345/#comment161512>
ditto
3rdparty/libprocess/configure.ac (lines 818 - 820)
<https://reviews.apache.org/r/39345/#comment161501>
Does FreeBSD require this? If not then split the cases.
3rdparty/libprocess/src/tests/http_tests.cpp (lines 872 - 876)
<https://reviews.apache.org/r/39345/#comment161513>
Please add a comment why the test is disabled, as a TODO.
configure.ac (line 985)
<https://reviews.apache.org/r/39345/#comment161500>
Does FreeBSD support all those architectures? I suspect not, so this should
be split out.
src/slave/containerizer/isolators/posix/disk.cpp (line 418)
<https://reviews.apache.org/r/39345/#comment161516>
This is an interesting point... I think we actually care about the usage,
not the apparent size since we're using this for setting quota.
src/tests/attributes_tests.cpp (line 40)
<https://reviews.apache.org/r/39345/#comment161517>
Did this cause a problem running the tests or are you cleaning things up?
- Ian Downes
On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39345/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 12:45 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-1563
>
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enable build on FreeBSD, start porting components.
>
> My build steps are:
>
> - Install dependencies from http://mesos.apache.org/gettingstarted/
> - Install libexecinfo
> - Install clang36 (system clang is 3.4)
> - boostrap
> - ../configure --with-curl=/usr/local --with-apr=/usr/local
> --with-svn=/usr/local CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36 check
>
> I disabled one test because I haven't had a chance to debug it and I wanted
> to get a bit further in the test suite. A check run is attached.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am
> 53e83d4905945593e174601a0b791d01824dc34b
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
> dc7c6522b283916b975a77957909f6cdc02944d3
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
> 9428717fac4655898d7768957f02937592e1a398
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
> e49783a438157706b1be9745436bf666f45cab8b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
> 1c776cd2facfb86854c7b2a8fe6be7949b566587
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp
> PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp
> 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp
> 1baf142d53fd06149c80d4b2677c2a976c05ef71
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp
> 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp
> e9b05ef3b59fd068137cb12e36591de2d4a801a1
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp
> 0a98e9e310d3931c2341053595b7d62f68214783
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
> 8a8ede325cfe8f024e1be4db24b0c8118d18f359
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
> f16ef1998c9b271b35063a2f07cf1c15d6b8bea0
> 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
> 4cc781bddbf7ee10cc0671f62d710fb4fa80e293
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
> 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff
> 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff
> 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975
> 3rdparty/libprocess/src/tests/http_tests.cpp
> d13d3888abbf3db552df4a9f83e54667e598ded9
> configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9
> src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc
> src/slave/containerizer/isolators/posix/disk.cpp
> 73e62a225da062733557287afa2273d8183d76fd
> src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3
> src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697
> src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8
>
> Diff: https://reviews.apache.org/r/39345/diff/
>
>
> Testing
> -------
>
> make check on coreos (I'll get a ubuntu instance for future testing)
>
> gmake check on freebsd 10.2 (failing) (log attached)
>
>
> File Attachments
> ----------------
>
> check3.log
>
> https://reviews.apache.org/media/uploaded/files/2015/10/20/c6757057-d221-444f-8b61-0f853e568e9e__check3.log
>
>
> Thanks,
>
> David Forsythe
>
>
