----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103656 -----------------------------------------------------------
support/apply-reviews.py (line 25) <https://reviews.apache.org/r/38705/#comment161714> s/extract_// support/apply-reviews.py (line 32) <https://reviews.apache.org/r/38705/#comment161713> s/parent_review/review_chain/ ? support/apply-reviews.py (lines 41 - 42) <https://reviews.apache.org/r/38705/#comment161715> Shouldn't this comment be rephrased/killed since you are disallowing more than one immediate parent below? support/apply-reviews.py (line 56) <https://reviews.apache.org/r/38705/#comment161717> why extract summary into a variable here? you didn't do that above in #51. support/apply-reviews.py (line 57) <https://reviews.apache.org/r/38705/#comment161716> what if there is a circular dependency of reviews by mistake? A --> B --> C --> A support/apply-reviews.py (line 58) <https://reviews.apache.org/r/38705/#comment161718> Why do you need to take 'r_list' as an argument to this method? to catch circular dependencies? if not, you could've done something as follows? ``` def review_list(review_id): review = review_json(review_id) if len (review.depends) == 0 : return [review_id , review.summary] elif len (review.depends) == 1: return review_list(review.depends.id) + [review_id, review.summary] else: error() ``` - Vinod Kone On Oct. 20, 2015, 7:28 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38705/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 7:28 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38705/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
