> On Oct. 22, 2015, 9:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > <https://reviews.apache.org/r/38705/diff/8-9/?file=1100640#file1100640line25> > > > > s/extract_// > > Artem Harutyunyan wrote: > Marco commented earlier on this one `nit: you are 'masking' the global > builtin id() here - that's a PEP8 violation, could you please rename to > something like rid?`.
is the concern that if you call this method review_id(), you cannot use "review_id" as a variable in the method? if yes, you can call the local variable 'rid'. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103656 ----------------------------------------------------------- On Oct. 23, 2015, 6:16 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38705/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 6:16 a.m.) > > > Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, > and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38705/diff/ > > > Testing > ------- > > Tested the script with python 2.7. > > > Thanks, > > Artem Harutyunyan > >
