----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review103901 -----------------------------------------------------------
Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623] All tests passed. - Mesos ReviewBot On Oct. 24, 2015, 4:33 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 4:33 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > ----- > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > ------- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
