-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/
-----------------------------------------------------------

(Updated Oct. 24, 2015, 6:43 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
-------

Review comments


Bugs: MESOS-3515
    https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
-------

Refactored the `api/v1/executor` endpoint to do executor/framework 
exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
`frameworkID/executorID` when it launches it. Also modified tests to first 
spawn a dummy `cat` process and then make a `Subscribe` call to ensure that the 
Agent knows about the Framework/Executor and not reject it via `BadRequest` due 
to the `NULL` checks.


Diffs (updated)
-----

  src/slave/http.cpp 80bda34e2b344b96d5d2f9c1fecd36046f67ab49 
  src/tests/executor_http_api_tests.cpp 
31938c295367686d444f8a8aa2c43d2696b481ec 

Diff: https://reviews.apache.org/r/38875/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Reply via email to