-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review104010
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.cpp (line 998)
<https://reviews.apache.org/r/39401/#comment162194>

    s/dedicatedsorter/dedicated sorter/



src/master/allocator/mesos/hierarchical.cpp (line 1015)
<https://reviews.apache.org/r/39401/#comment162195>

    s/sort/sorts/?



src/master/allocator/mesos/hierarchical.cpp (line 1026)
<https://reviews.apache.org/r/39401/#comment162196>

    s/the/that/?



src/master/allocator/mesos/hierarchical.cpp (lines 1044 - 1046)
<https://reviews.apache.org/r/39401/#comment162197>

    s/the/that/
    
    Seems like a copy of the comment above, is this intentional?



src/master/allocator/mesos/hierarchical.cpp (line 1056)
<https://reviews.apache.org/r/39401/#comment162199>

    s/overcimmittment/overcommitment of/
    
    or 
    
    s/overcimmittment/overcommitting/



src/master/allocator/mesos/hierarchical.cpp (line 1057)
<https://reviews.apache.org/r/39401/#comment162200>

    s/guarantee/a guarantee/
    
    It'd be great to expand this comment a bit and describe what the gurantee 
represents.


- Artem Harutyunyan


On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to