-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review104258
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.cpp (line 1073)
<https://reviews.apache.org/r/39401/#comment162532>

    roleAllocatedResources also needs to be recalculated in the above 
frameworkSorters foreach loop everytime when we allocate resources to a 
framework of the role, otherwise the check (if quota for the role is satisfied) 
in that loop will not work as we expect, i.e., the result of that check will 
always true even we allocate some resources to frameworks.


- Qian Zhang


On Oct. 28, 2015, 3:27 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 3:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to