----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/#review104187 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp (lines 1403 - 1404) <https://reviews.apache.org/r/39415/#comment162475> Can you explain more? What if the slave restarts after creating the qdisc, the slave will flap afterwards? - Jie Yu On Oct. 18, 2015, 12:22 a.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39415/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 12:22 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When we enable --egress_unique_flow_per_container, we need to install an > fq_codel qdisc on root, but if a qdisc already exists on root, we should not > continue since it could be not fq_codel at all, so just exit with error. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef > > Diff: https://reviews.apache.org/r/39415/diff/ > > > Testing > ------- > > Manual tests, with a pre-installed HTB qdisc and without. > > > Thanks, > > Cong Wang > >
