----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/#review104314 -----------------------------------------------------------
Ship it! Thanks Tim! src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 465) <https://reviews.apache.org/r/39719/#comment162571> Please add a `// NOTE:` header. src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 468) <https://reviews.apache.org/r/39719/#comment162572> Can you follow the syntax below: each command one line? ``` out << "cat /proc/self/mountinfo | " << "cut -d' ' -f5 | " // '-f5' is the mount target. << "xargs --no-run-if-empty mount --make-slave\n"; ``` I suggest we don't mask errors for this case because if this command does not work, we could end up with in a bad situation (the one you saw in the test). - Jie Yu On Oct. 28, 2015, 12:55 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39719/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 12:55 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3806 > https://issues.apache.org/jira/browse/MESOS-3806 > > > Repository: mesos > > > Description > ------- > > Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806 > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > a126cd6ee15adb8d92e85ab562e998e3647f999a > > Diff: https://reviews.apache.org/r/39719/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
