-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39719/#review104835
-----------------------------------------------------------


As Alex suggested, please update cmakelist as well.


src/Makefile.am (line 860)
<https://reviews.apache.org/r/39719/#comment163100>

    Probably call this mount.hpp|cpp. See comments below.



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 469 - 470)
<https://reviews.apache.org/r/39719/#comment163101>

    ```
    MesosContainerizerMount::Flags mountFlags;
    mountFlags.operation = MesosContainerizerMount::MAKE_RSLAVE;
    mountFlags.path = "/";
    
    ...
    ```



src/slave/containerizer/mesos/mark_mounts_rslave.hpp (line 36)
<https://reviews.apache.org/r/39719/#comment163099>

    I am thinking about making this more general and can be extended in case we 
need to (e.g., supporting make-slave, make-rshared, or other mount operation).
    
    How about calling this Subcommand:
    `MesosContainerizerMount`
    
    ```
    class MesosContainerizerMount : public Subcommand
    {
    public:
      static constexpr char NAME[] = ""
      static constexpr char MAKE_RSLAVE[] = "make-rslave";
      
      struct Flags : public flags:: FlagsBase
      {
        Flags();
        
        std::string operation;
        Option<std::string> path;
      };
    };
    
    int MesosContainerizerMount::execute()
    {
      if (flags.operation == MAKE_RSLAVE) {
        if (flags.path.isNone()) {
          ..
        }
        
        fs::mount(...);
      } else {
        cerr << "Unknown operation: " << flags.operation;
        return 1;
      }
    }
    ```


- Jie Yu


On Nov. 2, 2015, 6:52 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39719/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3806
>     https://issues.apache.org/jira/browse/MESOS-3806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> a126cd6ee15adb8d92e85ab562e998e3647f999a 
>   src/slave/containerizer/mesos/main.cpp 
> 0e1793128b56ab2e0aa2d263383c9de47ffe25d1 
>   src/slave/containerizer/mesos/mark_mounts_rslave.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/mark_mounts_rslave.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to