This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 2, 2015, 5:06 p.m.)

Review request for mesos, Ben Mahler and Artem Harutyunyan.


Add a note to `upgrades.md`.

Bugs: MESOS-3771

Repository: mesos


We do not encode or otherwise preprocess the raw binary in the ExecutorInfo or 
TaskInfo `data` fields before outputting them to JSON via the state endpoints.  
This means that the outputted JSON may be invalid (i.e. non-UTF8) if `data` was 
filled in with arbitrary bytes.

The `data` fields are being removed because the state endpoints should not be 
writing binary data in the first place.

Diffs (updated)

  docs/upgrades.md 3854e59f68d53892b2673a4542ea2aaf96936cbb 
  src/common/http.cpp f56d8a178e1f61d91adfeaad32b47718adbc4379 
  src/slave/http.cpp d6df97fb64077fb051dd78fe35bf04e8be0331ff 

Diff: https://reviews.apache.org/r/39611/diff/

Testing (updated)

`make check` and visually checked markdown for correctness.

Apparently, none of our tests check these fields.  

(Discovered via manual tests) Our JSON parser (PicoJson) is not restrictive 
enough to catch the invalid-JSON that results.  It will happily parse the 
binary blobs (roundtripping successfully).


Joseph Wu

Reply via email to