-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39611/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 4:36 p.m.)
Review request for mesos, Ben Mahler and Artem Harutyunyan.
Changes
-------
Tweak upgrades.md.
Bugs: MESOS-3771
https://issues.apache.org/jira/browse/MESOS-3771
Repository: mesos
Description
-------
We do not encode or otherwise preprocess the raw binary in the ExecutorInfo or
TaskInfo `data` fields before outputting them to JSON via the state endpoints.
This means that the outputted JSON may be invalid (i.e. non-UTF8) if `data` was
filled in with arbitrary bytes.
The `data` fields are being removed because the state endpoints should not be
writing binary data in the first place.
Diffs (updated)
-----
docs/upgrades.md c7bf6a226fb6f5af8ef42bb9e9b843099fdd4e71
src/common/http.cpp abb4c6bc2fe547bdc3a15682bfa680a52acc75a8
src/slave/http.cpp d6df97fb64077fb051dd78fe35bf04e8be0331ff
Diff: https://reviews.apache.org/r/39611/diff/
Testing
-------
`make check` and visually checked markdown for correctness.
Apparently, none of our tests check these fields.
(Discovered via manual tests) Our JSON parser (PicoJson) is not restrictive
enough to catch the invalid-JSON that results. It will happily parse the
binary blobs (roundtripping successfully).
Thanks,
Joseph Wu
