----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review104842 -----------------------------------------------------------
Have you updated the Makefile since provisioner.hpp is removed in this patch? src/tests/containerizer/filesystem_isolator_tests.cpp (lines 119 - 124) <https://reviews.apache.org/r/39258/#comment163107> Can we just use Backend::create(flags) instead? src/tests/containerizer/filesystem_isolator_tests.cpp (line 281) <https://reviews.apache.org/r/39258/#comment163110> any reason you use 'copy'. Can we do bind to speed up tests? src/tests/containerizer/filesystem_isolator_tests.cpp (lines 319 - 327) <https://reviews.apache.org/r/39258/#comment163111> I think we can leverage the test utility `createTask` here to create the command line task. - Jie Yu On Nov. 2, 2015, 7:05 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39258/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2015, 7:05 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Add filesystem isolator with command executor test. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > 39008f6201777783d242407fea5377bfceffc57b > src/tests/containerizer/provisioner.hpp > 507e1413470ef4f36ead657203073115d5324bef > > Diff: https://reviews.apache.org/r/39258/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
