-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39258/#review102697
-----------------------------------------------------------



src/slave/containerizer/provisioner/provisioner.hpp (line 101)
<https://reviews.apache.org/r/39258/#comment160452>

    Can you move this comment up at the class level.
    
    ```
    // Expose this class for testing only.
    ```



src/tests/containerizer/filesystem_isolator_tests.cpp (lines 100 - 102)
<https://reviews.apache.org/r/39258/#comment160460>

    Instead of doing that, can we combine two 'createContainerizer' methods 
into one? In other words, let's always use the real provisioner with TestStore. 
Let's still keep the existing createContainerizer interface (i.e., taking a 
hashmap from image name to rootfs path).



src/tests/containerizer/filesystem_isolator_tests.cpp (lines 280 - 306)
<https://reviews.apache.org/r/39258/#comment160461>

    You should be able to get rid of the logics here by doing what I suggested 
above.


- Jie Yu


On Oct. 13, 2015, 3:40 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39258/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 3:40 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add filesystem isolator with command executor test.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/slave/containerizer/provisioner/provisioner.hpp 
> 912fc5abadb1219fc4baec1a751010522bc7a7d0 
>   src/slave/containerizer/provisioner/provisioner.cpp 
> 30a85a52ee5986c6e1652edfd08ae881280b23ab 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 1e332e0d36ac2812456514aa030f995b3a07dca1 
>   src/tests/containerizer/store.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39258/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to