> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16>
> >
> >     AFAIK this isn't Java-specific.
> 
> Isabel Jimenez wrote:
>     This will mostly impact Java frameworks since they'll have to not only 
> update the generated protos but change their framework code. See: 
>     
> https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249
> 
> Neil Conway wrote:
>     Sorry, I'm still confused: updating the generated protos will require 
> changes to framework code (if your framework examines the `secret` field), 
> regardless of language. e.g., the type of the field has changed from []byte 
> to string in the Go generated code.

True, let me remove the language specificity.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104953
-----------------------------------------------------------


On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 6 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3560
>     https://issues.apache.org/jira/browse/MESOS-3560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mention to Credential protobuf change in 0.26 in uprades.md
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 3854e59 
> 
> Diff: https://reviews.apache.org/r/39908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to