-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38900/#review105142
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp (line 3343)
<https://reviews.apache.org/r/38900/#comment163536>

    Can you add a NOTE here saying that if switch_user flag is false and the 
slave runs under a non-root user, the task will be rejected by the Posix 
filesystem isolator. Linux filesystem isolator requires slave to have root 
permission.


- Jie Yu


On Nov. 4, 2015, 8:59 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38900/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 8:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3428
>     https://issues.apache.org/jira/browse/MESOS-3428
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update command executor to support rootfs.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/slave/constants.hpp de6b58a93346c618a9214032d891c1004203ca56 
>   src/slave/constants.cpp b69471b2d57aad0c254ef3bb7dce9405abeab93a 
>   src/slave/slave.hpp e6fa66b40c7f17c500056b7d6f95d7e795a16ca0 
>   src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 
>   src/tests/slave_tests.cpp 91dbdba56c7d3a374e56be92d88c0b367c7a2e1c 
> 
> Diff: https://reviews.apache.org/r/38900/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to