----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105134 -----------------------------------------------------------
src/Makefile.am (line 564) <https://reviews.apache.org/r/38580/#comment163530> We use tab indentation in the Makefilm.am src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp (line 57) <https://reviews.apache.org/r/38580/#comment163540> I think this is redudant. src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp (line 69) <https://reviews.apache.org/r/38580/#comment163541> We talked about removing these right? And it's not matching the actual params src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 43) <https://reviews.apache.org/r/38580/#comment163542> We don't use alias namespaces tpyically. src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 51) <https://reviews.apache.org/r/38580/#comment163543> Didn''t you pull these out? src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 129) <https://reviews.apache.org/r/38580/#comment163544> Move the timeout after into the RemotePullerProcess. src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 133) <https://reviews.apache.org/r/38580/#comment163546> Let the caller LOG instead of us since we already forward all necessary information to the caller. src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 213) <https://reviews.apache.org/r/38580/#comment163548> Remove extra space src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 216) <https://reviews.apache.org/r/38580/#comment163547> Fix indentation src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 236) <https://reviews.apache.org/r/38580/#comment163553> Let's use consistent failure messaging here. If you like to include the layer id please include in both cases, and also specify the layer as well for all cases. src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 295) <https://reviews.apache.org/r/38580/#comment163555> Are you trying to check for custom registry? The Name struct has an optional registry field that you should check instead: if (name.has_registry()) { return Error(.....); } src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 303) <https://reviews.apache.org/r/38580/#comment163556> Can you rebase on all your refactoring patches? src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 373) <https://reviews.apache.org/r/38580/#comment163558> Instead of doing this, how about just create a new Image::Name? src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 380) <https://reviews.apache.org/r/38580/#comment163559> Remove extra space between ' and : src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp (line 385) <https://reviews.apache.org/r/38580/#comment163560> ditto src/slave/flags.cpp (line 118) <https://reviews.apache.org/r/38580/#comment163537> This is only used in the remote puller for now, so perhaps say "for pulling images from the Docker registry" src/slave/flags.cpp (line 123) <https://reviews.apache.org/r/38580/#comment163538> How about "Default Docker registry server host" src/slave/flags.cpp (line 128) <https://reviews.apache.org/r/38580/#comment163539> Default Docker registry server port - Timothy Chen On Nov. 4, 2015, 6:09 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38580/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 6:09 p.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Integrated remote puller with store. Tests will follow. > > > Diffs > ----- > > src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 > src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 87d80026939a326bd1169f46906e36d6ef19f546 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > f314f20d989ed0125e15d2a14d0f8e56c56976d5 > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 8010b8aa75a2fc2e4b537f915f9dca028e407b63 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > ad57d8592c5f9df5115b575855ed2e99a0597359 > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp > PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp > PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/store.cpp > bb02d650e16d45fcf337a7954f7a26143fb2c69f > src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 > src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 > src/tests/containerizer/provisioner_docker_tests.cpp > 8d90894410cd834edf49a2814d1b616718798fe8 > > Diff: https://reviews.apache.org/r/38580/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
