----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review105200 -----------------------------------------------------------
Ship it! src/master/master.cpp (lines 4410 - 4418) <https://reviews.apache.org/r/39792/#comment163621> Would be great to continue wrapping comment paragraphs at 70 even though it's not a hard rule, for consistency with the large amount of existing comment paragraphs and to make it easier to read. src/master/master.cpp (lines 4417 - 4418) <https://reviews.apache.org/r/39792/#comment163620> What can be made a CHECK? That the uuids match? Also, how is 0.27.0 relevant given the notes about old checkpointed updates above? Would be great to clarify this in the comment. src/slave/slave.cpp (lines 3025 - 3028) <https://reviews.apache.org/r/39792/#comment163622> Ditto, would be great to wrap at 70 to be consistent with the rest of this function and the code in general. :) src/slave/slave.cpp (lines 3025 - 3028) <https://reviews.apache.org/r/39792/#comment163623> Ah.. I see. It was a bit confusing to read your remarks about old checkpointed updates in the master code, can you remove that and perhaps just reference the invariants before and after 0.26.0? Was a bit confusing for me. - Ben Mahler On Nov. 2, 2015, 7:32 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39792/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2015, 7:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This just makes sure master and slave properly set the uuid in task status to > setup the stage for deprecating the messy logic in scheduler driver in a > future release. > > > Diffs > ----- > > src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac > src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 > src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 > src/slave/slave.cpp 5f9b52b41eaab0c24965f28e192074340e00bde5 > > Diff: https://reviews.apache.org/r/39792/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
