----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105237 -----------------------------------------------------------
Looks great, but we need to fix the consistency issue between the configuration.md and flags.cpp, and not recommend ``cat resources.txt``. docs/attributes-resources.md (lines 45 - 49) <https://reviews.apache.org/r/39102/#comment163757> Provide at least one example with a role docs/attributes-resources.md (line 104) <https://reviews.apache.org/r/39102/#comment163758> Inconsistent spacing after ':'s docs/attributes-resources.md (line 164) <https://reviews.apache.org/r/39102/#comment163762> Why ``cat resources.txt`` instead of `--resources=file:///path/to/resources.txt`? docs/attributes-resources.md (line 166) <https://reviews.apache.org/r/39102/#comment163763> Note: the "default role" is set by `--default_role` docs/configuration.md (line 1398) <https://reviews.apache.org/r/39102/#comment163764> Did you change src/slave/flags.cpp to match this new description? docs/configuration.md (line 1406) <https://reviews.apache.org/r/39102/#comment163765> Other JSON flags have text like: "The value could be a JSON formatted string of rules or a\n" "file path containing the JSON formated rules used in the endpoints\n" "firewall. Path must be of the form 'file:///path/to/file'\n" "or '/path/to/file'.\n" - Adam B On Nov. 4, 2015, 9:26 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39102/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 9:26 a.m.) > > > Review request for mesos, Adam B and Neil Conway. > > > Bugs: MESOS-2467 > https://issues.apache.org/jira/browse/MESOS-2467 > > > Repository: mesos > > > Description > ------- > > Added documentation for JSON resources. > > > Diffs > ----- > > docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 > docs/configuration.md 195814cf918e018d8287113299163415b94ab09f > > Diff: https://reviews.apache.org/r/39102/diff/ > > > Testing > ------- > > Viewed the relevant documentation sections ('Attributes and Resources' & > 'Configuration') using the mesos-website-container: > https://github.com/mesosphere/mesos-website-container > > > Thanks, > > Greg Mann > >