----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105288 -----------------------------------------------------------
include/mesos/master/allocator.hpp (lines 355 - 356) <https://reviews.apache.org/r/38218/#comment163799> This bit is somewhat unclear: "the group of roles with quota set" sounds like it is referring to an argument, but it's actually referring to the implementation, right? include/mesos/master/allocator.hpp (lines 370 - 371) <https://reviews.apache.org/r/38218/#comment163800> Suggestion: s/with quota and without/with or without quota/ - Joseph Wu On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38218/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 9:38 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3716 > https://issues.apache.org/jira/browse/MESOS-3716 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 > src/master/allocator/mesos/allocator.hpp > c5375aa89b210e46c41ac7d68d119749de15d2f5 > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/38218/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
