> On Nov. 6, 2015, 2:40 p.m., Joerg Schad wrote: > > include/mesos/master/allocator.hpp, line 357 > > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line357> > > > > s/given role not set/nonexisting role?
This sentence refers to an existing role without quota. Do you think it's not clear that the role exists? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105422 ----------------------------------------------------------- On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38218/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:29 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3716 > https://issues.apache.org/jira/browse/MESOS-3716 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 > src/master/allocator/mesos/allocator.hpp > c5375aa89b210e46c41ac7d68d119749de15d2f5 > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/38218/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
